Skip to content

fix: --config flag ignored when placed before subcommand #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
privateip merged 1 commit into from
Mar 4, 2026
Merged

fix: --config flag ignored when placed before subcommand #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/itential_mcp/runtime/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,10 @@ def _create_subparsers(parser: cli.Parser, global_options_parser: cli.Parser) ->
cmd = subparsers.add_parser(
command_config.name,
description=command_config.description,
parents=[global_options_parser],
)

# Add command-specific arguments
for arg_name, arg_config in command_config.arguments.items():
# Skip --config as it comes from parent parser
if arg_name == "--config":
continue
if arg_name.startswith("--"):
cmd.add_argument(arg_name, **arg_config)
else:
Expand Down
2 changes: 1 addition & 1 deletion tests/test_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ async def mock_async_func():

mock_run_cmd.return_value = (mock_async_func, None, None)

app.parse_args(["run", "--config", "/path/to/config.ini"])
app.parse_args(["--config", "/path/to/config.ini", "run"])

assert os.environ.get("ITENTIAL_MCP_CONFIG") == "/path/to/config.ini"

Expand Down