This repository was archived by the owner on Aug 27, 2024. It is now read-only.
Switch to use Artifactory to avoid rate limit#87
Open
sellers wants to merge 1 commit into
Open
Conversation
Please use docker-virtual for all image pulls from Dockerhub or related cached repositories. Failure to do so will cause service outage, build failures, or other problems with your system and it will happen randomly and unexpectedly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please use docker-virtual for all image pulls from Dockerhub or related cached repositories. Failure to do so will cause service outage, build failures, or other problems with your system and it will happen randomly and unexpectedly.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This fixes a hazard with rate limit to pull image which will result in an incident if not fixed.
What is the current behavior? (You can also link to an open issue here)
Image pulls will fail if not cached on the given node or on the system, experience will be random and non-deterministic. Remediation when incident occurs will be this exact PR, causing a new build, and deploy.
What is the new behavior (if this is a feature change)?
It will pull from Artifactory, and be successful 99.9% of the time.
Other information: