Skip to content

fix(storybook): restore Styles/Tokens/Sass pages and fix GlobalColors…#1286

Merged
satya-achanta-venkata merged 13 commits into
developfrom
bugfix/storybook-design-tokens
Jun 8, 2026
Merged

fix(storybook): restore Styles/Tokens/Sass pages and fix GlobalColors…#1286
satya-achanta-venkata merged 13 commits into
developfrom
bugfix/storybook-design-tokens

Conversation

@satya-achanta-venkata

@satya-achanta-venkata satya-achanta-venkata commented May 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #1214

Restore Styles/Tokens/Sass pages and fix GlobalColors…

  • Rename 6 style story files from .jsx to .ts/.tsx to match Storybook glob patterns narrowed
  • Fix tokens.color['Marble gray'] → tokens.color['marble-gray'] in both WC and React token stories

This change: (check at least one)

  • Adds a new feature
  • Fixes a bug
  • Improves maintainability
  • Improves documentation
  • Is a release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the: (complete all)

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite(s) passing?
  • Code coverage maximal?
  • Changeset added?

What does this change address?
This change addresses broken style related token stories in WebComponents and React storybooks

How does this change work?
In #991 we narrowed our glob patterns to .ts/.tsx but some of these token related stories still in .jsx format. In this PR, we converted those files into .ts | .tsx format

Additional context

Screenshot with latest change

Screenshot 2026-05-29 at 3 20 02 PM

@satya-achanta-venkata
fix(storybook): restore Styles/Tokens/Sass pages and fix GlobalColors…
98bff44 
… error

- Rename 6 style story files from .jsx to .ts/.tsx to match Storybook
glob patterns narrowed in #991 (Convert stories to TypeScript)
- Fix tokens.color['Marble gray'] → tokens.color['marble-gray'] in both
WC and React token stories
@satya-achanta-venkata
fix(storybook): Add changelog
4c144cc
@satya-achanta-venkata satya-achanta-venkata requested a review from a team as a code owner May 29, 2026 19:37
@satya-achanta-venkata satya-achanta-venkata requested review from jialin-he, lizlove and sirrah-tam and removed request for a team May 29, 2026 19:37
@changeset-bot

changeset-bot Bot commented May 29, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 80c57fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented May 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
packages/pharos/lib/index.js 1.05 MB (0%)

brentswisher
brentswisher reviewed Jun 2, 2026
View reviewed changes
Comment thread packages/pharos/src/styles/sass.wc.stories.ts Outdated
brentswisher
brentswisher reviewed Jun 2, 2026
View reviewed changes
Comment thread .changeset/tender-drinks-stay.md Outdated
brentswisher
brentswisher reviewed Jun 2, 2026
View reviewed changes
Comment thread packages/pharos/src/styles/tokens.react.stories.tsx Outdated
brentswisher
brentswisher requested changes Jun 4, 2026
View reviewed changes

@brentswisher brentswisher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satya-achanta-venkata - I'm not quite sure I am following why playwright was added as a dependency for this?

@satya-achanta-venkata

satya-achanta-venkata commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@brentswisher Ignore that please. I was just testing my own observation with that addition and as an evidence for today's Pharos OPs. I am going to bring this up in today's Pharos OPs and will take corresponding action basing on that

Update: Removed it.

@satya-achanta-venkata satya-achanta-venkata merged commit bee2c39 into develop Jun 8, 2026
11 checks passed
@satya-achanta-venkata satya-achanta-venkata deleted the bugfix/storybook-design-tokens branch June 8, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brentswisher brentswisher brentswisher approved these changes

@phosphotungstic phosphotungstic phosphotungstic approved these changes

@sirrah-tam sirrah-tam Awaiting requested review from sirrah-tam sirrah-tam is a code owner automatically assigned from ithaka/pharos-maintainers

@lizlove lizlove Awaiting requested review from lizlove lizlove is a code owner automatically assigned from ithaka/pharos-maintainers

@jialin-he jialin-he Awaiting requested review from jialin-he jialin-he is a code owner automatically assigned from ithaka/pharos-maintainers

Assignees

No one assigned

Labels

status/code review storybook

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Styles, design tokens and mixins no longer viewable in Storybook

3 participants

@satya-achanta-venkata @brentswisher @phosphotungstic