Ensure checkbox checked property stays synced across elements#1303
Open
brentswisher wants to merge 1 commit into
Open
Ensure checkbox checked property stays synced across elements#1303brentswisher wants to merge 1 commit into
brentswisher wants to merge 1 commit into
Conversation
brentswisher
requested review from
JimFeather,
daneah and
jialin-he
and removed request for
a team
|
Contributor
size-limit report 📦
|
daneah
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
Closes #1302
How does this change work?
The input inside the checkbox was previously rendered with an attribute binding,
?checked=${this.checked}. Switching to a property binding wrapped in Lit's live() directive:.checked=${live(this.checked)}will ensure it stays in sync no matter if it is clicked or changes programmatically.https://lit.dev/articles/lit-cheat-sheet/#attribute-and-property-expressions-(binding-syntax)
Additional context
Technically, just the property binding change would fix the initial bug report. Adding
live()will ensure that the element can't get out of sync if something upstream catches thechangeevent and cancels it. We set that event to be cancellable here to support links in the checkbox label, so this seemed the most complete way to ensure the checkbox remains in sync.