Repository navigation
refactor(workspace): share semantic source updates across LSP and MCP - #418
Merged
Merged
Conversation
Owner
|
🤖 Начата автоматическая приёмка — этот pull request взят в работу ИИ-агентом: |
The server numbers its own requests (window/workDoneProgress/create) from 1, so a hover response awaited by bare id could match a server request with the same id. The legacy-extension-scope test now waits through Lsp::request, which requires a response shape, and a harness test pins that a same-id server request is skipped. wait_for_within dropped a message that arrived just past its deadline; it now returns it to the pending queue for the next wait. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wait_for_within checked its deadline before reading the queue, so a wait whose bound had already run out answered silence over a message that had arrived, and one taken in just past the bound was set aside unjudged, which wait_for_judging then reported as a silent server. The bound is now checked after each message: unrelated traffic still cannot stretch a wait, and a zero remainder polls once instead of seeing nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wait_for_judging checked its total ceiling before the predicate, so a matching message delivered in time but taken in just past the ceiling, as a late wake-up of the test thread leaves it, failed the wait instead of answering it. The predicate now judges first; unrelated traffic still cannot carry a wait past the ceiling. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
added 2 commits
October 15, 2026 01:23
…space-analysis # Conflicts: # crates/mcp-server/src/lib.rs # crates/test-utils/src/walk_probe.rs
Owner
|
🤖 Автоматическая приёмка завершена: изменения приняты, PR влит коммитом 44dd995. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LSP and MCP resident updates duplicated file registration, FileSet changes and metadata invalidation. This change moves that ordering into
ide-host-coreand routes both adapters, CLI loading and bounded graph batches through the shared source-update code.It preserves editor-overlay versus disk views, lazy readiness, cancellation/retry ownership, independent scopes/cache leases and existing protocol/configuration formats. It also delivers the existing compatibility-mode setting to MCP and fixes source exclusion/readmission and config reload feedback.
Validation on current head
2c5dbc62:Check: formatting, all-target/all-feature Clippy and the fullcargo test --all --no-fail-fastpassed.Corpus contractandWindows MCP transports + secure brokerpassed. The Windows job runs its configured transport/cache/lease selection, not the full Windows workspace.The first Linux CI run exposed a timing-dependent graph test setup: it prepared a snapshot after handing ownership away. The follow-up test-only correction prepares before each refusal condition and explicitly observes the takeover before installation. The old setup deterministically fails that control; the corrected exact test and the fresh full CI run pass, preserving all three refusal/debt assertions.
Performance remains advisory and unconfirmed. Previous LSP numeric failures are retained; the corrected G0-only calibration was inconclusive for 34/68 metrics, so the paired candidate run was not started. The final-binary core/MCP comparison is incomplete. This PR does not claim lower memory use or absence of startup/latency/RSS regression.
BA-067 graph metadata lookup is intentionally delivered in a separate PR.
Closes #384.