adding a rotate feature for pdfs#133
Merged
itsjunetime merged 5 commits intoitsjunetime:mainfrom Feb 19, 2026
Merged
Conversation
Owner
|
Yeah, I think this generally makes sense, no real issues right now. Thanks for doing this :) You'll want to run |
IshDeshpa
changed the title
IshDeshpa
force-pushed
the
rotate_feature
branch
from
fa4699b to
9b51a8d
Compare
Contributor
Author
|
Think this is ready for review. |
itsjunetime
approved these changes
Feb 19, 2026
Owner
itsjunetime
left a comment
itsjunetime
left a comment
There was a problem hiding this comment.
This is great and seems to work perfectly! All the code is good, and the only thing that I think needs changing is that the r key binding is not present in the help text (which appears when you hit ?) - could you add it there? Once it's there, I'll be happy to merge this in.
Contributor
Author
|
For sure! |
Owner
|
Thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently a work in progress. I need to figure out how to rotate in a way such that I can scroll past the original rectangular bounds of the page when zoomed in. Also for some reason scrolling too much starts scaling the page a bit.
I had to fix a bug in mupdf involving incorrect 270 deg rotation matrix to get it to work in its current form.
Any feedback on implementation details would be much appreciated, as well as how to go forward from what I have now. I'm new to Rust so let me know if there's anything that is wrong.