Skip to content

EQ Client Settings: red EXPERIMENTAL save warning (v3.24.50)#17

Merged
itsnateai merged 1 commit into
mainfrom
feat/experimental-save-warning
Jun 7, 2026
Merged

EQ Client Settings: red EXPERIMENTAL save warning (v3.24.50)#17
itsnateai merged 1 commit into
mainfrom
feat/experimental-save-warning

Conversation

@itsnateai

@itsnateai itsnateai commented Jun 7, 2026

Copy link
Copy Markdown
Owner

Adds a red EXPERIMENTAL - SAVE AT OWN RISK label to the right of the Save/Apply/Cancel buttons on the main EQ Client Settings window, while the 6-window subsystem is mid-rebuild (Phases 5–10 still pending).

  • New semantic colour DarkTheme.FgDanger (bright red) — keeps the "all colours in DarkTheme" rule.
  • AutoSize label at x=528 (Cancel ends at 520 in the 750px client) → clears the buttons, fits at 100% & 150%.
  • Version bumped to v3.24.50 + CHANGELOG entry, so this is release-ready: merge → tag v3.24.50 → CI release.

Verified: clean Debug and Release build (Release strips the test harness via #if DEBUG); --diag-render-form EQClientSettingsForm renders without crash.

Ready to merge whenever; main stays safe at v3.24.49 until you tag.

Summary by CodeRabbit

  • New Features
    • Added a prominent red "EXPERIMENTAL — SAVE AT OWN RISK" warning notice to the EQ Client Settings window, positioned alongside the Save/Apply/Cancel buttons. This alerts users that saving from experimental forms is performed at their own risk as the system undergoes ongoing updates and refinements.

…ngs (v3.24.50)

Adds a red 'EXPERIMENTAL - SAVE AT OWN RISK' label to the right of the Save/Apply/Cancel buttons on the main EQ Client Settings window while the 6-window subsystem is mid-rebuild (Phases 5-10 pending). New semantic DarkTheme.FgDanger (bright red). Label is AutoSize at x=528 (Cancel ends at 520 in the 750px client) so it clears the buttons and fits at 100%/150%.
@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 224bfa43-136f-48c3-844e-1b8b1d3c99aa

📥 Commits

Reviewing files that changed from the base of the PR and between 32cfb30 and 92639e8.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • EQSwitch.csproj
  • UI/DarkTheme.cs
  • UI/EQClientSettingsForm.cs

📝 Walkthrough

Walkthrough

This PR adds an experimental warning notice to the EQ Client Settings form. A new danger color constant is introduced to the dark theme, used to style a red "EXPERIMENTAL - SAVE AT OWN RISK" label in the form's button panel. The application version is bumped to 3.24.50 and documented in the changelog.

Changes

Experimental Warning Notice

Layer / File(s) Summary
Danger color theme constant
UI/DarkTheme.cs
New FgDanger semantic color constant (bright red) added for danger/warning styling in UI components.
Warning label in settings form
UI/EQClientSettingsForm.cs
"EXPERIMENTAL - SAVE AT OWN RISK" label added to the bottom button panel using the new danger color, alongside Save/Apply/Cancel buttons.
Version bump and release documentation
EQSwitch.csproj, CHANGELOG.md
Application version incremented to 3.24.50 and changelog entry added describing the new experimental warning notice in the settings window.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding a red experimental warning label to EQ Client Settings, and includes the version bump (v3.24.50) which is relevant context.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/experimental-save-warning

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@itsnateai itsnateai merged commit 92639e8 into main Jun 7, 2026
3 checks passed
@itsnateai itsnateai deleted the feat/experimental-save-warning branch June 7, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant