Move F in DualNum from parameter to associated type - #115
Merged
Merged
Conversation
prehner
force-pushed
the
primitive_type
branch
2 times, most recently
from
August 8, 2026 14:52
c455186 to
16710ef
Compare
|
Awesome, thanks so much for addressing this so quickly! The new API is working well here. |
prehner
force-pushed
the
primitive_type
branch
2 times, most recently
from
August 11, 2026 13:23
cc9ae68 to
c819b5d
Compare
Contributor
Author
|
@g-bauer what do you think? |
prehner
force-pushed
the
primitive_type
branch
from
August 11, 2026 13:32
c819b5d to
4eb7b4a
Compare
Contributor
|
Looks good to me. |
prehner
force-pushed
the
primitive_type
branch
from
August 12, 2026 11:17
4eb7b4a to
b5430b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @dwuertz for the suggestion!
The underlying primitive (mostly
f32orf64) should be an associated type ofDualNumrather than a type parameter, because there is only one reasonable choice per implementation. It wasn't because of some troubles with orphan rule and the implementation of arithmetic operations with floats. However, with the right trait bounds, the compiler can apparently be satisfied. This also completely removes thePhantomData<F>fields from all dual number types.In places that are hardcoded to a specific float precision (e.g., FeOs) this basically means that every occurrence of
DualNum<f64>needs to be replaced withDualNum<Primitive = f64>which is somewhat cumbersome but overall not a limitation.