fix(settings): Address Obsidian plugin review warnings - #37
Merged
Conversation
- Use createDiv() helper instead of activeDocument.createElement to follow Obsidian's prefer-create-el guideline. - Implement getSettingDefinitions() so settings appear in Obsidian's settings search for users on 1.13.0 or later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Obsidian's plugin review flagged two warnings that affect compliance and discoverability: direct DOM creation instead of the recommended helper, and settings not appearing in the built-in settings search for users on 1.13.0+.
Description
Applies the two fixes from the review so the plugin follows Obsidian guidelines and its settings become searchable.
Changes
activeDocument.createElement("div")with Obsidian'screateDiv()helper inmessage-row.ts(prefer-create-el).getSettingDefinitions()(plusgetControlValue/setControlValue) insettings-tab.tsso settings surface in Obsidian's settings search on 1.13.0+. The interactivedisplay()UI is unchanged.