Add ability to view video transcripts to the Invidious frontend #5298
Conversation
This commit adds a server-side UI template that renders a transcript element. This is used to render transcripts for users without JS.
Innertube structure was changed
|
|
||
| addEventListener("DOMContentLoaded", () => { | ||
| const transcriptLines = document.getElementById("lines"); | ||
| for (const transcriptLine of transcriptLines.children) { |
There was a problem hiding this comment.
I'd recommend adding the click event listener on transcriptLines and checking the event's target. This would have better performance than adding an event listener onto each transcriptLine
| } | ||
| }); | ||
|
|
||
| addEventListener("DOMContentLoaded", () => { |
There was a problem hiding this comment.
I don't remember if internet explorer is still a supported browser or not but arrow functions aren't supported in IE. So if it is still supported it will need to be changed. https://caniuse.com/arrow-functions
| addEventListener("DOMContentLoaded", () => { | |
| addEventListener("DOMContentLoaded", function() { |
| margin: 0; | ||
| } | ||
|
|
||
| .transcript-line:hover, .selected.transcript-line, .transcript-title-line:hover, .selected.transcript-title-line { |
There was a problem hiding this comment.
Hovering looks great on light mode, but it doesn't look great on dark mode (the default used by invidious).
| .transcript-line:hover, .selected.transcript-line, .transcript-title-line:hover, .selected.transcript-title-line { | |
| .transcript-line:hover, .selected.transcript-line, .transcript-title-line:hover, .selected.transcript-title-line { | |
| background: #4f4f4f; | |
| } | |
| .light-theme .transcript-line:hover, .selected.transcript-line, .transcript-title-line:hover, .selected.transcript-title-line { | |
| background: #cacaca; | |
| } |
With the suggestion, it now looks like this:
|
In testing on https://inv.nadeko.net with my CSS suggestion applied |
|
What's missing to get this upstream? |
4 participants
Closes #2564
The current description box isn't really designed to hold non preformatted content hence the extraneous spacing at the bottom. Once #4111 is merged the description box should get a redesign to better accommodate these description widgets and how they should be affected by the expand description user preference.