BUG: Solved "TypeError: Cannot read property 'length' of undefined" e…#47
Open
JohnEricson wants to merge 3 commits into
Open
BUG: Solved "TypeError: Cannot read property 'length' of undefined" e…#47JohnEricson wants to merge 3 commits into
JohnEricson wants to merge 3 commits into
Conversation
…rror when using slider connected to datasource in CDE dashboard. The cause of the problem is that sliderData.resultset.length is executed before sliderData = values, resulting in the slider failing to render on start of the dashboard.
Author
|
My bad! This doesn't really solve the problem. Now it uses the hardcoded minRange, maxRange in properties instead of taking them from the datasource query. |
added 2 commits
September 1, 2015 14:07
…'length' of undefined". Earlier my solution disabled fromRange, toRange from datasource. Now I solved this by triggering the rest of the rendering code of the slider after the data is retrieved successfully. Code is inspired from CDF components.
Author
|
Now I've fixed so the solution works with datasource queries as earlier. I would like this fix to be pulled into master. |
Member
|
Hi @JohnEricson, Thanks for your contribution. 😄 I'll give a test soon. Joel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves "TypeError: Cannot read property 'length' of undefined" error when using slider connected to datasource in CDE dashboard. The cause of the problem is that sliderData.resultset.length is executed before sliderData = values, resulting in the slider failing to render on start of the dashboard.
Complete error: