Skip to content

UI improvements#24

Open
ketsuban wants to merge 1 commit intoizik1:masterfrom
ketsuban:master
Open

UI improvements#24
ketsuban wants to merge 1 commit intoizik1:masterfrom
ketsuban:master

Conversation

@ketsuban
Copy link

@ketsuban ketsuban commented Feb 5, 2020

  • Removed font override (0.7rem is tiny)
  • Removed oversized min-width on opcode table

* Removed font override (`0.7rem` is *tiny*)
* Removed oversized `min-width` on table
@izik1
Copy link
Owner

izik1 commented Feb 10, 2020

Hi @ketsuban, thank you for your PR, I really do appreciate it.

I'm not going to close this, as I'm open to discussion, however, I don't particularly like these changes as is:

  • Changing the font size there causes the table to 2d scroll, which I try to avoid
  • The min-width is a hack to avoid stuff like the image below text (overflow)

overflow

@izik1 izik1 force-pushed the master branch 2 times, most recently from 0fe5c6a to 65dce0d Compare July 20, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants