feat(headless): pump the streamer in WARMUP + add bOnSideStand differ… - #1
Open
paulostation wants to merge 1 commit into
Open
feat(headless): pump the streamer in WARMUP + add bOnSideStand differ…#1paulostation wants to merge 1 commit into
paulostation wants to merge 1 commit into
Conversation
…ential test Two changes plus reproduction docs, on top of j0y base 5650884. 1. game_tests.cpp: the WARMUP phase now services the on-demand streaming queue (CStreaming::LoadRequestedModels() per frame, LoadAllRequestedModels(false) flush before tests). Without this the headless frame loop never drives the queue -- requested models never stream in (census loaded_bikes=0), silently blocking every test that needs a streamed model. Safe here: WARMUP runs before SuspendOtherThreads, so CdStreamThread is still alive. Same calls the game itself uses (Pools.cpp, Game.cpp). 2. test_CCarCtrl_GetNewVehicle_diff.cpp: behavioural differential test for CCarCtrl::GetNewVehicleDependingOnCarModel (0x421440, paulo-sysframe PR j0y#1). Runs the ORIGINAL machine code (via HookDisableGuard) vs the reversed C++ on each loaded bike and compares bikeFlags.bOnSideStand, with vacuous-pass guards (compared/bikesSeen/onSideStandTrue/origSetFlag all > 0). 3. docs/: reproduction manifest (exact commands, GAME_TEST_REQUEST_MODELS + WARMUP_FRAMES, expected 34-assertion PASS, and a falsification check), the PR#1 CarCtrl reversal diff for reference, and the write-up. Result: PASS CCarCtrl/Diff_GetNewVehicleDependingOnCarModel (34 assertions), STATUS=PASS, reproduced twice. PR j0y#1's bOnSideStand write proven faithful to the original, headless.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ential test
Two changes plus reproduction docs, on top of j0y base 5650884.
game_tests.cpp: the WARMUP phase now services the on-demand streaming queue (CStreaming::LoadRequestedModels() per frame, LoadAllRequestedModels(false) flush before tests). Without this the headless frame loop never drives the queue -- requested models never stream in (census loaded_bikes=0), silently blocking every test that needs a streamed model. Safe here: WARMUP runs before SuspendOtherThreads, so CdStreamThread is still alive. Same calls the game itself uses (Pools.cpp, Game.cpp).
test_CCarCtrl_GetNewVehicle_diff.cpp: behavioural differential test for CCarCtrl::GetNewVehicleDependingOnCarModel (0x421440, paulo-sysframe PR feat(headless): pump the streamer in WARMUP + add bOnSideStand differ… #1). Runs the ORIGINAL machine code (via HookDisableGuard) vs the reversed C++ on each loaded bike and compares bikeFlags.bOnSideStand, with vacuous-pass guards (compared/bikesSeen/onSideStandTrue/origSetFlag all > 0).
docs/: reproduction manifest (exact commands, GAME_TEST_REQUEST_MODELS + WARMUP_FRAMES, expected 34-assertion PASS, and a falsification check), the PR#1 CarCtrl reversal diff for reference, and the write-up.
Result: PASS CCarCtrl/Diff_GetNewVehicleDependingOnCarModel (34 assertions), STATUS=PASS, reproduced twice. PR #1's bOnSideStand write proven faithful to the original, headless.