Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix insecure CORS preflight routing - #30

Open
jackby03 wants to merge 1 commit into
mainfrom
sentinel-fix-cors-middleware-7666048950231908019
Open

jackby03 wants to merge 1 commit into
mainfrom
sentinel-fix-cors-middleware-7666048950231908019

Conversation

@jackby03

@jackby03 jackby03 commented Sep 9, 2026

Copy link
Copy Markdown
Owner

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Insecure CORS Preflight Handler Route Binding. The OPTIONS route for /api/v1/auth/login was explicitly mapped to the srv.handleLogin business logic handler.
🎯 Impact: Unauthenticated CORS preflight requests (OPTIONS) could improperly invoke or hit business logic meant only for authenticated/intended POST requests.
πŸ”§ Fix: Refactored corsMiddleware from http.HandlerFunc to http.Handler and moved it to wrap the global ServeMux instance. Removed explicit OPTIONS route binding entirely.
βœ… Verification: Ran go test ./cmd/... successfully. All CORS functionality still fully tested.


PR created automatically by Jules for task 7666048950231908019 started by @jackby03

Refactored `corsMiddleware` to operate as an `http.Handler` wrapper that applies globally to the entire `ServeMux`, rather than wrapping individual routes. This safely intercepts `OPTIONS` requests before routing and removes the insecure practice of directly mapping an `OPTIONS` route to a business logic handler.

Co-authored-by: jackby03 <70082129+jackby03@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant