Skip to content

modernize, cleanup, prevent unnessecary valCopies. #2440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
the-hotmann wants to merge 1 commit into
base: master
Choose a base branch
from
+1,780 −1,638
Open

modernize, cleanup, prevent unnessecary valCopies. #2440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions batch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,14 +493,14 @@ func (br *emptyBatchResults) Close() error {
func invalidateCachesOnBatchResultsError(conn *Conn, b *Batch, err error) {
if err != nil && conn != nil && b != nil {
if sc := conn.statementCache; sc != nil {
for _, bi := range b.QueuedQueries {
sc.Invalidate(bi.SQL)
for i := range b.QueuedQueries {
sc.Invalidate(b.QueuedQueries[i].SQL)
}
}

if sc := conn.descriptionCache; sc != nil {
for _, bi := range b.QueuedQueries {
sc.Invalidate(bi.SQL)
for i := range b.QueuedQueries {
sc.Invalidate(b.QueuedQueries[i].SQL)
}
}
}
Expand Down
8 changes: 4 additions & 4 deletions bench_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func BenchmarkMinimalUnpreparedSelectWithoutStatementCache(b *testing.B) {

var n int64

for i := 0; b.Loop(); i++ {
for i := range b.N {
err := conn.QueryRow(context.Background(), "select $1::int8", i).Scan(&n)
if err != nil {
b.Fatal(err)
Expand All @@ -66,7 +66,7 @@ func BenchmarkMinimalUnpreparedSelectWithStatementCacheModeDescribe(b *testing.B

var n int64

for i := 0; b.Loop(); i++ {
for i := range b.N {
err := conn.QueryRow(context.Background(), "select $1::int8", i).Scan(&n)
if err != nil {
b.Fatal(err)
Expand All @@ -89,7 +89,7 @@ func BenchmarkMinimalUnpreparedSelectWithStatementCacheModePrepare(b *testing.B)

var n int64

for i := 0; b.Loop(); i++ {
for i := range b.N {
err := conn.QueryRow(context.Background(), "select $1::int8", i).Scan(&n)
if err != nil {
b.Fatal(err)
Expand All @@ -112,7 +112,7 @@ func BenchmarkMinimalPreparedSelect(b *testing.B) {

var n int64

for i := 0; b.Loop(); i++ {
for i := range b.N {
err = conn.QueryRow(context.Background(), "ps1", i).Scan(&n)
if err != nil {
b.Fatal(err)
Expand Down
Loading