Allow editing session start time in session complete sheet - #24
Open
JWAY21 wants to merge 3 commits into
Open
Conversation
Replaces the non-editable start time display with a wheel DatePicker, mirroring the existing end time editing behaviour. The start time picker is capped to ≤ selectedEndTime, and the end time picker lower bound updates to selectedStartTime, keeping the range mutually consistent. The adjusted start time is written through to the saved VitaminDSession and HealthKit entry. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
When the user edits the start or end time on the Session Complete sheet, the vitamin D synthesized amount now updates automatically 0.5 s after the wheel stops spinning. The new amount scales proportionally to the adjusted duration (newDuration / originalDuration × sessionAmount), preserving the UV/skin/clothing weighting from the live session. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
JWAY21
added a commit
to JWAY21/sunday
that referenced
this pull request
Jun 8, 2026
… mcg to PR jackjackbits#24 PR jackjackbits#24 includes a comprehensive rewrite of SessionCompletionSheet that already handles IU/mcg display using currentAmount. Keeping the same changes in PR jackjackbits#25 would cause a duplicate @AppStorage declaration (compile error) when both PRs are merged. PR jackjackbits#25 now only touches ContentView: the UNITS toggle card, convertUnit() helper, and updated rate/session/today displays. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Without this the HealthKit sample was always stamped with the moment the user tapped "Save to Health" (Date() default), not with the corrected session start time. The adjusted start time was only written to the SwiftData record, not to HealthKit. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
JWAY21
added a commit
to JWAY21/sunday
that referenced
this pull request
Jun 8, 2026
…prehensive version Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The "Session Complete" sheet currently shows start time as a non-editable label. This PR replaces it with a wheel `DatePicker` that mirrors the existing end time picker, so users can correct the start time if they forgot to start the timer right away.
When either time is adjusted, the VITAMIN D SYNTHESIZED amount recalculates automatically ~0.5 s after the wheel settles — so the figure always reflects the corrected duration, not the raw tracked time.
How it works
Testing