Add IU/mcg units toggle and move skin type into control row - #25
Open
JWAY21 wants to merge 2 commits into
Open
Conversation
Adds a UNITS card alongside skin type so all four per-session controls (clothing, sunscreen, skin type, units) sit in two symmetric rows. Tapping UNITS toggles between IU and mcg (1 mcg = 40 IU), persisted via AppStorage. The vitamin D rate, session, and daily total displays in ContentView and the session completion sheet all respect the selected unit. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… mcg to PR jackjackbits#24 PR jackjackbits#24 includes a comprehensive rewrite of SessionCompletionSheet that already handles IU/mcg display using currentAmount. Keeping the same changes in PR jackjackbits#25 would cause a duplicate @AppStorage declaration (compile error) when both PRs are merged. PR jackjackbits#25 now only touches ContentView: the UNITS toggle card, convertUnit() helper, and updated rate/session/today displays. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
JWAY21
added a commit
to JWAY21/sunday
that referenced
this pull request
Jun 8, 2026
…e to ContentView only Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Adds a UNITS control card alongside skin type, so all four per-session controls (clothing, sunscreen, skin type, units) sit in two symmetric rows. Tapping UNITS toggles the display between IU and mcg (1 mcg = 40 IU), matching Apple Health's native unit for vitamin D.
How it works
@AppStorage("usesMCG")persists the preference across sessionsunitsSectioncard sits alongsideskinTypeSectionin a matchingHStack, giving skin type the same width/position as the clothing cardconvertUnit(_:)helper converts IU → mcg when the toggle is onTesting