fix(regimes): show ETH rule diagnostics without a compatible HMM - #68
Merged
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ETH current regime and timeline failed when its HMM artifact was absent or incompatible, even when the existing economic rules matched actual observations. The current endpoint now returns the rule diagnostic independently; no match remains Unknown. Missing model probabilities remain empty, confidence remains unavailable, and history preserves unmatched intervals instead of smoothing them into a regime.
The page displays the missing-model limitation and actual API error reason, clears stale charts on failure and clears errors after recovery. ETH history no longer includes Bitcoin events. The displayed expansion threshold now matches the implemented +15%/30d rule. No training, return forecasting, private data export or dependencies are added.
Validation: four new backend regression cases and two real-component frontend cases passed; existing reliability/authentication regressions passed (25 + 34 focused backend tests). Robot2 deployment will use a small image layer based on the current production image, preserving configuration and rollback. Merge remains gated on CI success.