fix(regimes): keep ETH timeline consistent with updated prices - #69
Merged
Merged
Conversation
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ETH can show Expansion in its current card while the historical chart stays Bull Market for the same day. The four-hour history cache did not detect revised closes, and a one-day chart zone had identical start/end coordinates.
Invalidate cached histories when the actual public price history changes, including revisions on the same date. Give daily zones their full daily interval and mark the latest observation with its regime color. Show the actual BTC/ETH rule trigger in the comparison table and align the expansion description with the implemented +15%/30d threshold.
Validation: 26 focused backend assertions passed; the isolated five-test run passed with global-suite coverage disabled (the initial focused invocation hit the whole-repository coverage threshold). Three chart component tests and targeted Ruff passed. Real robot2 observations reproduce the stale cached Bull Market vs fresh Expansion mismatch for 2026-10-02. No training, private portfolio exports or dependency changes.
Production verification on robot2: authenticated desktop 1440px and mobile 390px show current/comparison/latest history all Expansion on 2026-10-02, the latest blue marker is visible, the daily zone has nonzero width, and the actual recovery rule replaces the hard-coded Bear criterion. No JS errors or horizontal overflow; Docker healthy, HTTP /healthz 200, zero restarts; private CSV/cash/configuration and runtime mounts/env/network aliases preserved. Previous container retained for rollback.