[codex] fix(cli): allow dash-leading positional adapter args#1223
Draft
Yinchaochen wants to merge 1 commit intojackwener:mainfrom
Draft
[codex] fix(cli): allow dash-leading positional adapter args#1223Yinchaochen wants to merge 1 commit intojackwener:mainfrom
Yinchaochen wants to merge 1 commit intojackwener:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opencli boss detail -123456abdc -f jsonRoot Cause
Commander treated values like
-123456abdcas unknown options before OpenCLI's adapter argument preparation ran, so commands with positional IDs could fail before adapter-level validation had a chance to handle them.Impact
Commands such as
opencli boss detail -123456abdc -f jsonnow parse the positionalsecurity-idcorrectly instead of failing withunknown option.Validation
npm run typechecknpm test -- --runInBand src/commanderAdapter.test.tsnpm run buildnpm test(fails on this Windows environment due pre-existing unrelated symlink/path separator assertions insrc/plugin.test.ts,src/engine.test.ts, and several adapter download/upload tests)Fixes #1160