feat(plugin): make esbuild resolution resilient to package managers#366
Merged
feat(plugin): make esbuild resolution resilient to package managers#366
Conversation
2870e02 to
0f9ea24
Compare
jackwener
approved these changes
Mar 24, 2026
Owner
jackwener
left a comment
There was a problem hiding this comment.
Deep review completed. I kept the esbuild resolution fallback idea, rebased it onto current plugin infrastructure, and kept the patch focused on the actual resilience fix plus targeted coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the hardcoded
node_modules/.bin/esbuildlookup with a robust multi-stage resolution strategy.resolveEsbuildBin()with 3 fallbacksimport.meta.resolveto parse the actually installedesbuild/package.jsonand find its declared bin file.node_modules/.binpath.which esbuild.transpilePluginTs()to use this new helper.This prevents silent
transpilePluginTsfailures on developer machines or custom environments where package managers likepnpmhoist bins differently.