refactor: use CliError subclasses in remaining adapters#367
Merged
Conversation
Replace raw Error throws with appropriate CliError subclasses: - linkedin/timeline.ts: AuthRequiredError, EmptyResultError - linkedin/search.ts: ArgumentError, CommandExecutionError This enables better error handling and user-facing error messages.
Replace raw Error throws with appropriate CliError subclasses: - twitter/trending.ts: AuthRequiredError, EmptyResultError - twitter/bookmarks.ts: AuthRequiredError, CommandExecutionError This enables better error handling and user-facing error messages.
Replace raw Error throws with appropriate CliError subclasses: - reddit/read.ts: CommandExecutionError for API-related errors This enables better error handling and user-facing error messages.
- linkedin/timeline: AuthRequiredError, EmptyResultError - linkedin/search: ArgumentError, CommandExecutionError - bilibili/subtitle: AuthRequiredError, CommandExecutionError, EmptyResultError, SelectorError - bilibili/following: CommandExecutionError - medium/shared: CommandExecutionError - twitter/delete, twitter/unfollow: CommandExecutionError This allows the top-level error handler to render consistent, helpful output with emoji-coded severity and actionable hints.
…ters Replace raw Error throws with appropriate CliError subclasses: - youtube/transcript.ts: CommandExecutionError, EmptyResultError - youtube/video.ts: CommandExecutionError - bilibili/utils.ts: EmptyResultError - boss/send.ts: EmptyResultError, SelectorError - boss/mark.ts: ArgumentError, EmptyResultError This enables better error handling and user-facing error messages.
Owner
Author
|
Review summary:
I checked the actual diff and validated the branch on latest
Result: No blocker from my side. The only follow-up is process-level: keep the PR description aligned with the real changed files next time, because this branch touches more adapters than the summary says. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues error refactor work for bilibili and medium adapters. 223 tests pass.