Open
Conversation
raw_rendering Enhance ScrollRegion with full content and computed scrollbars Include full lines, scrollTop, scrollLeft in ScrollRegion to allow render-worker to compute visible area and scrollbars. Remove explicit Scrollbar objects from Output and metadata. Avoid duplicating scroll region content in main updates Mask out scroll regions in TerminalBuffer.update to prevent sending their content in the main update payload. Render the content of scroll regions in the worker using renderOverlays. Checkpoint Process Support sticky bottom
jacob314
force-pushed
the
render_cache_3
branch
from
31025b5 to
93b1b26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
raw_rendering
Enhance ScrollRegion with full content and computed scrollbars
Include full lines, scrollTop, scrollLeft in ScrollRegion to allow render-worker to compute visible area and scrollbars. Remove explicit Scrollbar objects from Output and metadata.
Avoid duplicating scroll region content in main updates
Mask out scroll regions in TerminalBuffer.update to prevent sending their content in the main update payload. Render the content of scroll regions in the worker using renderOverlays.
Checkpoint
Process
Support sticky bottom