Add routing activation timeout check and client logical address verification#68
Open
1ozZ wants to merge 2 commits intojacobschaer:mainfrom
Open
Add routing activation timeout check and client logical address verification#681ozZ wants to merge 2 commits intojacobschaer:mainfrom
1ozZ wants to merge 2 commits intojacobschaer:mainfrom
Conversation
…ication Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Owner
|
The assertion in test_activation_times_out_with_only_mismatched_addresses is flaky. There's two possible exceptions that can be raised. You could possibly change the assertion to Or you could catch the inner TimeoutError and reraise with your desired tiemout |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add timeout handling and stricter response validation for logical addressing.