fix(gh-nudge): fetch all open PRs instead of capping at 10#180
Merged
Conversation
GetPendingPullRequests used `gh pr status -q ".createdBy"`, but `gh pr status` is hardcoded to return at most 10 PRs and exposes no --limit flag, so users with more than 10 open PRs lost the rest silently. Both gh-nudge and gh-merge share this fetch path. Switch to `gh pr list --author "@me" --limit 100`, which preserves the "open PRs created by me" semantics and the same JSON array shape while supporting an explicit limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh-nudge(andgh-merge, which shares the same fetch path) only ever processed 10 pull requests. The root cause was inGetPendingPullRequests(devtools/gh-nudge/internal/github/github.go), which used:gh pr statusis hardcoded to return at most 10 PRs and exposes no--limitflag, so any user with more than 10 open PRs silently lost the rest.Fix
Switch to
gh pr list --author "@me" --limit 100 --json ..., which:pullRequestListLimit = 100constant (gh's own default is only 30).GetMergeablePullRequests(used bygh-merge) is fixed transitively since it callsGetPendingPullRequests.Testing
make format,make lint(0 issues),make test— all pass.TestGetPendingPullRequestscases only feed mock JSON output and don't assert command args for this function, so they remain valid unchanged.