feat(gh-nudge): skip draft PRs when nudging#181
Merged
Conversation
Draft PRs are not yet ready for review, so nudging their reviewers is noise. Fetch the isDraft field from the gh CLI and filter drafts out of GetPendingPullRequests so neither the nudge nor the auto-merge path acts on them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh-nudge previously nudged reviewers on all open PRs authored by the user, including drafts. Draft PRs aren't ready for review, so those nudges are noise.
This change fetches the
isDraftfield from theghCLI and filters drafts out ofGetPendingPullRequests(), so neither the nudge path nor the auto-merge path (which builds on it) acts on draft PRs.Changes
internal/models/pr.go— addedIsDraft boolfield toPullRequest.internal/github/github.go— addedisDraftto thegh pr list --jsonquery and filtered out drafts inGetPendingPullRequests(). PRs missing the field default to non-draft (backward-safe).internal/github/github_test.go— added tests covering draft skipping and the missing-field default.Testing
make checkpasses via the pre-commit hook: 292 + 4 Bazel tests pass, 0 golangci-lint / semgrep findings.