Some feedback for thesis and code#6
Open
steve-s wants to merge 1 commit into
Open
Conversation
steve-s
commented
Jul 14, 2022
|
|
||
|
|
||
| Is there anywhere explained why you chose bytecode style interpreter over AST? You could say it was part of the problem statement: is it feasible to implement .NET interpreter in one person and will using the bytecode interpreter approach pionieered by Espresso work for .NET and deliver cleaner/leaner/faster (interpreter speed) implementation than AST style interpreter already implemented by [...] and [...]. | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Mozna ze i otazka, zda parser nativniho .NET assembly formatu muze neco prinest (rychlost, lower memory, ...) by mohla byt formulovana jako soucasti zadani.
steve-s
commented
Jul 14, 2022
|
|
||
| Truffle's official mechanism of calling into native code is called the Native Function Interface (NFI). Unfortunately, at the time of designing BACIL, it was missing key features, for example support of custom ABIs (calling conventions). | ||
|
|
||
| Dalo by se tohle vyresit tak, ze si clovek udela trampolinu v C, ve ktere uz muze udelat libovolny marshalling, volani pres jinou konvenci, atd. Ta trampolina by mela vhodnout volaci konvenci a brala by data ve formatu, ktery se hodil BACILu, ale pak by je mohla zmasirovat na cokoliv na nativni strane. |
Collaborator
Author
There was a problem hiding this comment.
Mel byt otaznik na konci
steve-s
commented
Jul 14, 2022
| - Small number of tests | ||
| - I am not a big fan of "unit test every little trivial helper", but some amount of | ||
| integration tests like a bunch of C# programs and a driver that executes them on | ||
| BACIL/dotnet and compares the output would be nice. EDIT: I see there's the .NET's own test suite, that's good. Still some more custom tests would be great. |
Collaborator
Author
There was a problem hiding this comment.
Kdyz o tom vic premyslim, ty codegen testy z dotnet netestuji treba veci jako nacitani assemblies s ruznymi zavislostmi, nacteni nejake malformed assembly, nacteni assembly dvakrat, atd. veci tykajici se runtime ne primo compileru. To by byly i celkem smysluplne testy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.