Conversation
Prevents i/o while generating nonces. Also switched to urandom.
Implement support for SSL and for PUT and DELETE methods in oauth_netclient_http_client. This change adds new dependencies: ssl and equeue-ssl
Ryland, Add netclient support for SSL, PUT, and DELETE
…(parameter encoding takes care of this already)
support oauth_callback, fix PLAINTEXT signing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Factual API (http://developer.factual.com/display/docs/Core+API+-+Oauth) is using 2-legged OAuth, in which the Authorization header contains the oauth_consumer_key and oauth_signature but not the oauth_token parameter. This just makes the token parameters in Oauth_client.access_resource optional so it is possible to generate the correct signature for this api. Also the findlib name of ocurl has changed from "ocurl" to "curl" so this would support the newer version.