Cache reverse navigations for large repository performance - #25
Open
benjiwolff wants to merge 1 commit into
Open
Cache reverse navigations for large repository performance#25benjiwolff wants to merge 1 commit into
benjiwolff wants to merge 1 commit into
Conversation
benjiwolff
changed the title
benjiwolff
marked this pull request as ready for review
April 25, 2026 09:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In large repositories, it can take a second to find the matching file. It is then a bit unexpected, that switch back takes another second even though the connection between header and source file has been made.
I would prefer, if the reverse navigations were cached immediately.
Thoughts
This changes the behavior slightly: The reverse navigation will not respect the
extension_preferences. However, this is a general problem withextension_preferencespotentially allowing non-switching navigations (e.g.file.h->file.cpp->file.hppusing default settings).