Skip to content

Update requirements: fix failing test#112

Open
SumanthRH wants to merge 8 commits into
jalammar:mainfrom
SumanthRH:update_transformers
Open

Update requirements: fix failing test#112
SumanthRH wants to merge 8 commits into
jalammar:mainfrom
SumanthRH:update_transformers

Conversation

@SumanthRH

Copy link
Copy Markdown

Hi @jalammar , looks like I missed a commit on #110. All updates are on 68d8931 . Changes since last time:

  • change import of top_k_top_p_filtering
  • Use raw string in regex search to get rid of DeprecationWarning:
DeprecationWarning: invalid escape sequence '\.'
    layer_number = re.search("(?<=\.)\d+(?=\.)", name).group(0)

I've run pytest tests locally (python 3.10) and all tests pass. This should work now!

@SumanthRH SumanthRH changed the title Update transformers: fix failing test Update requirements: fix failing test Jan 24, 2024
@SumanthRH

Copy link
Copy Markdown
Author

Ping @jalammar. I've also added a small test for bfloat16 and it works!

Also, I believe the pre-commit hooks need to be updated (had some issues), so I will add that in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant