fix: make Portainer deploy from compose state - #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problema
Portainer despliega el stack desde
infra/<env>/compose.ymly no debe depender de que cargue un.envversionado del repositorio. Los Compose interpolabanIMAGE_REPO/IMAGE_TAG, por lo que la imagen podía quedar sin resolver.Cambios
ghcr.io/.../app:<tag>yworker:<tag>viven directamente en los Compose.cd-main,cd-promotey el botón de release actualizan esas líneas encompose.yml..envversionados pasan a.env.sample; se eliminan los.envoperativos..env.cisólo como fixtures para validar Compose./docker-apps/moodleshield-test/docker-apps/moodleshield-probootstrap-host.shy la documentación quedan alineados con esas rutas y con Portainer leyendo únicamente el Compose.IMAGE_REPO/IMAGE_TAGal Compose y que existan ambas imágenes completas.Validación
docker compose config -qpara test, prod y local..envlocal usando sólo variables del stack.npm run lint.npm test— 58 tests correctos.