dev by jamesjohnsdev · Pull Request #14 · jamesjohnsdev/issues

jamesjohnsdev · 2026-06-17T14:04:05Z

ci: added GHA workflows - general CI checks for code quality and correct builds - standard test runs on PRs - fuzz testing
ci: dependabot
chore: add codeowners
feat: added command
doc: updated readme
feat: added complete command
feat: enabled creation direct passthrough to editor
refactor: rename complete => close to match GH terminology
feat: improved display for issue list
fix: correct parsing of local issue numbers
test: test suites added
test: added fuzz testing

Summary by cubic

Adds a delete command, view, close, and create -e, improves list output, and tightens CI (linting, vuln checks, tests, fuzzing). Unifies ID parsing across commands (now rejects partial numeric IDs like "123abc") and fixes editor handling (supports flags in $VISUAL/$EDITOR, cleans up on abort).

New Features
- issues delete <id> deletes a local issue; prompts to also delete from GitHub if synced; cleans up originals; accepts numbers and T-ids.
- issues create -e opens a blank issue in your editor; discards if saved without a title; supports editor flags.
- issues view <id> opens an issue by number or T-id in your editor; supports editor flags.
- issues close <id> marks an issue closed and moves it to closed/ (no-op if already closed).
- issues list sorts numerically, shows GitHub issues before local T issues, and uses clearer, aligned columns.
- Unified ID parsing across commands, and push accepts numbers or T-ids; rejects partial numeric IDs.
Migration
- Use issues close (renamed from complete). Help text and docs now use the issues binary.

^{Written for commit 5f3127e. Summary will update on new commits.}

- general CI checks for code quality and correct builds - standard test runs on PRs - fuzz testing

enables users to open isses with default editor synatax

binary name didn't match actually command

doc: added `close` command to readme

cubic-dev-ai

7 issues found across 22 files

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="README.md">

<violation number="1" location="README.md:14">
P2: README references `issues` throughout but the binary's root command is `issue` (cmd/root.go:12 Use: "issue"). Users running `issues` will get a command-not-found error.</violation>
</file>

<file name="cmd/create.go">

<violation number="1" location="cmd/create.go:20">
P2: `--editor` mode currently accepts any extra positional args and ignores them. Validate that editor mode uses zero positional args to avoid silent input loss.</violation>

<violation number="2" location="cmd/create.go:66">
P2: `--editor` error path returns after file creation, leaving an empty issue file behind. Clean up the created file before returning this error.</violation>
</file>

<file name="cmd/util.go">

<violation number="1" location="cmd/util.go:94">
P1: `fmt.Sscanf(id, "%d", &number)` does not consume the full input, so inputs like "123abc" silently parse as 123 instead of returning an error</violation>
</file>

<file name=".github/dependabot.yml">

<violation number="1" location=".github/dependabot.yml:4">
P1: Both gomod blocks point at directories that do not exist in this repo, so Dependabot will never scan the actual root Go module.</violation>
</file>

<file name="cmd/view.go">

<violation number="1" location="cmd/view.go:34">
P2: Passing the raw editor string to exec.Command breaks editor values that include flags.</violation>
</file>

<file name="internal/issue/fuzz_test.go">

<violation number="1" location="internal/issue/fuzz_test.go:102">
P2: Round-trip check is unsound for bodies that start with newlines; Parse strips them, so the fuzz target will flag valid inputs as failures.</violation>
</file>

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

deletes local issue after checking sync status and providing optional delete of remote copy

it was incorrectly referencing two separate builds rather than the singular build required. This is a remnent of reusing this from another project.

cubic-dev-ai

1 issue found across 4 files (changes from recent commits).

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="cmd/delete.go">

<violation number="1" location="cmd/delete.go:47">
P1: Snapshot is deleted before confirming local issue file deletion. A failed local delete can leave the issue file present but disable modified detection for that issue.</violation>
</file>

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

cubic-dev-ai

1 issue found across 9 files (changes from recent commits).

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="cmd/delete.go">

<violation number="1" location="cmd/delete.go:47">
P1: Snapshot is deleted before confirming local issue file deletion. A failed local delete can leave the issue file present but disable modified detection for that issue.</violation>
</file>

<file name="cmd/list.go">

<violation number="1" location="cmd/list.go:44">
P1: Sort less function breaks strict weak ordering when Sscanf fails. When one path fails Sscanf but another succeeds, both `less(i,j)` and `less(j,i)` return false (considered equivalent). This breaks transitivity: if A≡B and B<C, then A must be < C, but A's Sscanf still fails → false. sort.Slice requires a strict weak ordering; violating it causes undefined behavior or panic.</violation>
</file>

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

Binary is named "issues" via go install; Use field was "issue", causing help text to show the wrong command name.

/transpiler and /lsp directories do not exist; dependabot was silently skipping go dependency updates. Remove the dead block and point the single gomod entry at /.

fmt.Sscanf does not require consuming the full input, so "123abc" silently parsed as 123. strconv.Atoi fails on any non-numeric input.

- Reject positional args when --editor is set instead of silently ignoring them - Remove the created file before returning the no-editor error to avoid leaving an empty orphan file behind - Split editor env var on whitespace so flags like "--wait" are passed correctly to exec.Command

VISUAL="code --wait" was passed as a single argument to exec.Command, causing a no-such-file error. Split on whitespace before constructing the command.

Parse calls strings.TrimLeft on the body, stripping leading newlines. Bodies that start with "\n" will never round-trip, so exclude them from the check the same way "\n---" inputs are already excluded.

cubic-dev-ai

2 issues found across 6 files (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

jamesjohnsdev · 2026-06-18T02:28:07Z

closes #10, #12

jamesjohnsdev added 12 commits June 17, 2026 22:39

ci: added GHA workflows

d2b7d37

- general CI checks for code quality and correct builds - standard test runs on PRs - fuzz testing

ci: dependabot

153e150

chore: add codeowners

2ae962d

feat: added command

88f81da

enables users to open isses with default editor synatax

doc: updated readme

f6233a9

binary name didn't match actually command

feat: added complete command

84ce84d

feat: enabled creation direct passthrough to editor

bda3718

refactor: rename complete => close to match GH terminology

bd486a1

doc: added `close` command to readme

feat: improved display for issue list

a7c1203

fix: correct parsing of local issue numbers

722a30b

test: test suites added

1b9e74c

test: added fuzz testing

2530941

cubic-dev-ai Bot reviewed Jun 17, 2026

View reviewed changes

Comment thread cmd/util.go Outdated

Comment thread .github/dependabot.yml

Comment thread README.md

Comment thread cmd/create.go Outdated

Comment thread cmd/create.go

Comment thread cmd/view.go Outdated

Comment thread internal/issue/fuzz_test.go

jamesjohnsdev added 3 commits June 18, 2026 09:25

chore: cleanup old references to issue command rather than issues

7d1b73b

feat: delete command

7d9de9b

deletes local issue after checking sync status and providing optional delete of remote copy

ci: fix main CI workflow

440fd43

it was incorrectly referencing two separate builds rather than the singular build required. This is a remnent of reusing this from another project.

cubic-dev-ai Bot reviewed Jun 18, 2026

View reviewed changes

Comment thread cmd/delete.go

chore: formating and unchecked errs

abd6765

cubic-dev-ai Bot reviewed Jun 18, 2026

View reviewed changes

Comment thread cmd/list.go

jamesjohnsdev added 6 commits June 18, 2026 11:56

fix(root): rename root command name to "issues"

c2e3b8a

Binary is named "issues" via go install; Use field was "issue", causing help text to show the wrong command name.

ci: point dependabot at root go module

5328d2f

/transpiler and /lsp directories do not exist; dependabot was silently skipping go dependency updates. Remove the dead block and point the single gomod entry at /.

fix(util): reject partial numeric ids such as "123abc"

257228c

fmt.Sscanf does not require consuming the full input, so "123abc" silently parsed as 123. strconv.Atoi fails on any non-numeric input.

fix(view): split editor string to support flags

5f90b97

VISUAL="code --wait" was passed as a single argument to exec.Command, causing a no-such-file error. Split on whitespace before constructing the command.

test(fuzz): skip round-trip body check for leading-newline inputs

32b811e

Parse calls strings.TrimLeft on the body, stripping leading newlines. Bodies that start with "\n" will never round-trip, so exclude them from the check the same way "\n---" inputs are already excluded.

cubic-dev-ai Bot reviewed Jun 18, 2026

View reviewed changes

Comment thread cmd/create.go

Comment thread cmd/create.go

This was referenced Jun 18, 2026

Runtime panic risk: if $VISUAL or $EDITOR contains only whitespace #16

Open

A failed local delete can leave the issue file present but disable modified detection for that issue #17

Closed

chore: mod tidy

5f3127e

jamesjohnsdev merged commit 35da3e6 into main Jun 18, 2026
8 checks passed

jamesjohnsdev deleted the dev branch June 18, 2026 02:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dev#14

dev#14
jamesjohnsdev merged 23 commits into
mainfrom
dev

jamesjohnsdev commented Jun 17, 2026 •

edited by cubic-dev-ai Bot

Loading

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jamesjohnsdev commented Jun 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

jamesjohnsdev commented Jun 17, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by cubic

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jamesjohnsdev commented Jun 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jamesjohnsdev commented Jun 17, 2026 •

edited by cubic-dev-ai Bot

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading