dev#41
Merged
Merged
Conversation
There was a problem hiding this comment.
2 issues found across 7 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
- on whitespace-only nvim returns empty slice, causing index-out-of-range panic; check len before exec - and on view are mutually exclusive; add early error instead of silently ignoring one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--webflag to open browser viewSummary by cubic
Adds browser support and closing comments to the CLI. You can open GitHub views with
--weband add a comment when closing an issue with--comment.New Features
list --webopens the GitHub issues list in the browser viagh.view --webopens the GitHub page for the issue; errors for local-onlyT*issues.close --commentopens $VISUAL/$EDITOR to draft a closing note; aborts on empty body. Comments are preserved when closing (comment file moved toclosed/).Bug Fixes
$VISUAL/$EDITORis empty or whitespace instead of panicking.view --weband--commentsare now mutually exclusive and error when used together.Written for commit 19184a1. Summary will update on new commits.