fix(delete): remove snapshot only after local file deletion succeeds#43
Merged
Conversation
A failed os.Remove on the issue file left the snapshot deleted, disabling modified detection for that issue on subsequent syncs. Closes #17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed os.Remove on the issue file left the snapshot deleted,
disabling modified detection for that issue on subsequent syncs.
Closes #17
Summary by cubic
Fix delete behavior to only remove a synced issue’s snapshot after the local file is successfully deleted. Prevents lost modified detection if the local delete fails. Closes #17.
Written for commit 849a1c9. Summary will update on new commits.