Skip to content

fix(delete): remove snapshot only after local file deletion succeeds#43

Merged
jamesjohnsdev merged 1 commit into
mainfrom
fix/failed-delete
Jun 21, 2026
Merged

fix(delete): remove snapshot only after local file deletion succeeds#43
jamesjohnsdev merged 1 commit into
mainfrom
fix/failed-delete

Conversation

@jamesjohnsdev

@jamesjohnsdev jamesjohnsdev commented Jun 21, 2026

Copy link
Copy Markdown
Owner

A failed os.Remove on the issue file left the snapshot deleted,
disabling modified detection for that issue on subsequent syncs.

Closes #17


Summary by cubic

Fix delete behavior to only remove a synced issue’s snapshot after the local file is successfully deleted. Prevents lost modified detection if the local delete fails. Closes #17.

  • Bug Fixes
    • Defer snapshot removal until after the local issue file is deleted; applies only to synced issues.
    • Added tests for local-only delete, synced delete success (snapshot removed), and delete failure (snapshot preserved).

Written for commit 849a1c9. Summary will update on new commits.

Review in cubic

A failed os.Remove on the issue file left the snapshot deleted,
disabling modified detection for that issue on subsequent syncs.

Closes #17

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@jamesjohnsdev jamesjohnsdev merged commit 3e35045 into main Jun 21, 2026
6 checks passed
@jamesjohnsdev jamesjohnsdev deleted the fix/failed-delete branch June 21, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A failed local delete can leave the issue file present but disable modified detection for that issue

1 participant