Open
Conversation
jamesmt-aws
force-pushed
the
k1-tag-consolidation-events
branch
2 times, most recently
from
96fc17b to
dae4d70
Compare
Store consolidationType on the consolidation base struct, set it in NewSingleNodeConsolidation and NewMultiNodeConsolidation. Prefix Unconsolidatable, ConsolidationCandidate, and ConsolidationRejected event messages with the consolidation type. Store ConsolidationLabel on Command for candidate and rejected events. Users seeing "Can't replace with a cheaper node" can now tell which evaluator produced the message. Ref: kubernetes-sigs#1962
jamesmt-aws
force-pushed
the
k1-tag-consolidation-events
branch
from
dae4d70 to
aad516b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unconsolidatable,ConsolidationCandidate, andConsolidationRejectedevent messages with the consolidation type (singleormulti)consolidationTypeparameter tocomputeConsolidation(),computeSpotToSpotConsolidation(),EmitCandidateEvents(), andEmitRejectedEvents()Motivation
In kubernetes-sigs/karpenter#1962, multi-node consolidation was silently skipped due to budget arithmetic. The user saw "Can't replace with a cheaper node" from single-node consolidation and reasonably assumed multi-node had tried and failed. Prefixing events with the controller name makes the diagnosis immediate.
Test plan
single: Can't replace with a cheaper node)