Log when multi-node consolidation is skipped due to budget#6
Open
jamesmt-aws wants to merge 1 commit intomainfrom
Open
Log when multi-node consolidation is skipped due to budget#6jamesmt-aws wants to merge 1 commit intomainfrom
jamesmt-aws wants to merge 1 commit intomainfrom
Conversation
jamesmt-aws
force-pushed
the
k2-log-multinode-skip
branch
from
18289cf to
93e062f
Compare
Add debug-level log messages when multi-node consolidation cannot run because budget filtering reduces candidates below the minimum of 2. Previously this was a silent early return that produced no output even at debug level. Ref: kubernetes-sigs#1962
jamesmt-aws
force-pushed
the
k2-log-multinode-skip
branch
from
93e062f to
49f24de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
firstNConsolidationOptionwhen called with fewer than 2 candidatesMotivation
In kubernetes-sigs/karpenter#1962, multi-node consolidation never ran because
ceil(5% * 20 nodes) = 1, which is below the minimum of 2 candidates. The controller returned silently with no log output, even at debug level. It took seven experiments to discover this silent early-return. A single log line would have made the root cause obvious.Test plan
nodes: "5%"budget on a 20-node cluster, verify debug log: "multi-node consolidation skipped, budget filtering reduced candidates below minimum of 2"