Conversation
✅ Deploy Preview for cute-starship-2d9c9b canceled.
|
jamesmunns
left a comment
There was a problem hiding this comment.
I think this is correct currently, but if we ever add an error variant that isn't just a discriminant, this could be subtly wrong. Also, varint_max is mostly intended for integers directly.
Would it be possible to use the postcard-derive MaxSize derive for this instead?
it would be but postcard-derive is currently only an optional experimental dependency of the postcard crate, so maybe we stick to a manual definition until thats not experimental anymore? |
fixes #224