Support serde_spanned::Spanned<T> deserialization#248
Open
gnosek wants to merge 1 commit intojamesmunns:mainfrom
Open
Support serde_spanned::Spanned<T> deserialization#248gnosek wants to merge 1 commit intojamesmunns:mainfrom
gnosek wants to merge 1 commit intojamesmunns:mainfrom
Conversation
✅ Deploy Preview for cute-starship-2d9c9b canceled.
|
Owner
|
I may not get to this until I've worked through the core bits of #241, just as a heads up! I'm catching up on things after being busy for a while. |
jamesmunns
added
the
Q2 '25 Triage
Author
|
No worries, I'll try to keep up with the merge conflicts :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide deserialization of serde_spanned::Spanned, which tracks the position of the value in the original serialized buffer.
(on serialization, the span data is ignored and only the inner T is serialized)
Note: I'm not particularly fond of reusing the original tests for testing spans, but I felt this is better than duplicating a large portion of the deserializer tests. Please let me know what you think.