Add postcard-schema::Schema implementations for bytes, indexmap, and log crates#279
Open
Calsign wants to merge 4 commits intojamesmunns:mainfrom
Open
Add postcard-schema::Schema implementations for bytes, indexmap, and log crates#279Calsign wants to merge 4 commits intojamesmunns:mainfrom
postcard-schema::Schema implementations for bytes, indexmap, and log crates#279Calsign wants to merge 4 commits intojamesmunns:mainfrom
Conversation
✅ Deploy Preview for cute-starship-2d9c9b canceled.
|
Calsign
force-pushed
the
postcard-schema-extern-crates
branch
from
4d53c2d to
b3ae13c
Compare
✅ Deploy Preview for cute-starship-2d9c9b canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I grouped these three crates together because I need all of them, I think they're fairly uncontroversial, and it reduces merge conflicts.
I added tests which round-trip each type through postcard serialization and then back through postcard-dyn and serde_json. I think this is the most robust way to verify that the schemas are correct, and it's a higher bar than other schema implementations have already.
There are other crates I would like to add schema definitions for, but I figured I would start with these.