Display Custom Error Messages With alloc Feature#81
Closed
zicklag wants to merge 1 commit intojamesmunns:mainfrom
Closed
Display Custom Error Messages With alloc Feature#81zicklag wants to merge 1 commit intojamesmunns:mainfrom
alloc Feature#81zicklag wants to merge 1 commit intojamesmunns:mainfrom
Conversation
✅ Deploy Preview for cute-starship-2d9c9b canceled.
|
iFreilicht
reviewed
Nov 11, 2022
Contributor
iFreilicht
left a comment
iFreilicht
left a comment
There was a problem hiding this comment.
I really like the concept overall, implementation is nice and the default message is very helpful.
zicklag
force-pushed
the
custom-error-messages
branch
from
c6c0811 to
b7d417c
Compare
iFreilicht
approved these changes
Nov 14, 2022
Contributor
iFreilicht
left a comment
iFreilicht
left a comment
There was a problem hiding this comment.
Looks good to me now. @jamesmunns, what do you think?
jamesmunns
added
the
Q2 '25 Triage
Owner
|
Closing this, however this is closely related to #157, and will likely be resolved in postcard 2.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #80.
I'm not sure if this is something you are interested in or not, but it got hard enough for me to go without it that I implemented it real quick. Let me know what you think!