Open
Conversation
👷 Deploy Preview for cute-starship-2d9c9b processing.
|
✅ Deploy Preview for cute-starship-2d9c9b canceled.
|
Author
|
Oh, and this is re: #95 |
rosslannen
pushed a commit
to lucimobility/postcard
that referenced
this pull request
Jan 30, 2026
Built on top of jamesmunns#83. The client does not work on Windows due to berkowski/tokio-serial#71 - it's annoying but workable in WSL using usbipd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two standalone commits here:
into()everywhere. Diff for my project looks like this:This seems... fragile. I did find a serde issue/PR where they wanted to do something similar, but it's old, not very active, and had a lot of feedback I didn't quite grok. This does manage to achieve exactly what I was looking for though, so I have a copy in my own codebase that I'm proceeding with. Changes to my project look like this:
There's probably a better way to make this stuff happen at the library level? Like ideally
use postcard::fixint::le::*would just magically configure it for your whole module, but that magic is beyond me still 🥲