Working in headless environments - #1
Conversation
2) replace qt packend for matplotlib with tk to prevent crash when used from command line 3) fix tests in the tests directory
2) fix to the report of number of columns tested 3) handle running in colab
jan-oko
left a comment
jan-oko
left a comment
There was a problem hiding this comment.
In general I'm guessing you asked me to pitch in for more of a high-level review, and from that perspective I think it's all right (at least as much as I can say from flipping through my pretty old code).
Take my suggestions or not (I don't think it's too important), and when you want tell me and I'll publish the update.
I should probably also give you permissions to do that, send me a username and I'll add you.
| setup( | ||
| name='dftest', | ||
| packages=['dftest'], | ||
| version='0.4.0', | ||
| version='0.5.4', | ||
| scripts=['bin/dftest'], | ||
| install_requires=deps, | ||
| description='A library for testing and analyzing data integrity.', | ||
| author='Atai Ambus', | ||
| author='Atai Ambus & Ran Gilad-Bachrach', | ||
| license='MIT' | ||
| ) |
There was a problem hiding this comment.
Consider instead using extra_requires
setup(
name='dftest',
packages=['dftest'],
version='0.5.4',
scripts=['bin/dftest'],
install_requires=deps,
extras_require={"gui": ["pandasgui"]}
description='A library for testing and analyzing data integrity.',
author='Atai Ambus & Ran Gilad-Bachrach',
license='MIT'
)Which would allow anyone who want to do pip install dftest[gui]
And still use the extra features. Then instead of doing if utils.in_colab() you could use try-except to skip import errors.
Alternatively if this really is useless (or you don't want to deal with changing the ifs) you should probably just remove the commented code (you can find it later in github anyway, if you need it).
Also, I'm guessing that the version is supposed to be 0.5.0 and not 0.4.0.
3 participants
Changes were made to support environments that do not support graphic interfaces. Therefore, we removed the dependency on pandagui, added the option to save to json file, and few other minor changes