fix(security): require authentication to place orders and enforce tok…#2363
Open
Prateek2007-cmd wants to merge 2 commits into
Open
fix(security): require authentication to place orders and enforce tok…#2363Prateek2007-cmd wants to merge 2 commits into
Prateek2007-cmd wants to merge 2 commits into
Conversation
|
@Prateek2007-cmd is attempting to deploy a commit to the janavipandole's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves Issue #2356 (Unauthenticated Order Placement).
The
/api/ordersendpoint previously lacked authorization controls, allowing anonymous unauthenticated users to create arbitrary database records. Furthermore, the endpoint trusted the email provided in the JSON payload, exposing the system to identity spoofing.This PR implements strict access control and enforces zero-trust identity mapping.
Changes Made
get_current_userJWT authorization dependency into thecreate_orderroute, immediately blocking anonymous requests with a401 Unauthorized.Ordermodel instantiation now ignoresorder_data.emailand directly mapscurrent_user.emailto the order, preventing malicious users from spoofing orders under other accounts.Type of Change