Fix/issue 2358 bounded lru captcha#2365
Open
Prateek2007-cmd wants to merge 4 commits into
Open
Conversation
…event OOM DOS attacks
|
@Prateek2007-cmd is attempting to deploy a commit to the janavipandole's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves Issue #2358 (Unbounded Memory Leak in Captcha Tracking).
The
/api/auth/loginendpoint utilized an unbounded global Python dictionary (failed_login_attempts) to track failed authentication requests. Because entries were only purged upon a successful login, a distributed botnet firing random email payloads could cause the dictionary footprint to expand infinitely, eventually starving the host environment of memory and crashing the service (DOS).This PR mitigates the architectural vulnerability by implementing a robust, self-cleaning caching layer.
Changes Made
OrderedDictto take advantage of O(1).move_to_end()and.popitem(last=False)operations.1000concurrent tracked emails. If the threshold is breached, the oldest tracked IP/email combination is dynamically purged, capping memory consumption effectively without degrading valid user UX.Type of Change