Skip to content

serdes-ai-models emits unused Arc import warning with no default features #74

Description

@acoliver

While verifying PR #66, these feature-matrix builds completed but emitted an unused import warning:

cargo check -p serdes-ai-models --no-default-features
cargo check -p serdes-ai-models --no-default-features --features responses-ws

serdes-ai-models/src/lib.rs:376 unconditionally imports std::sync::Arc inside build_model_with_config, while its uses are inside provider-feature-gated branches. With no provider features enabled, the import is unused. This file is unchanged by PR #66's current fixes.

Expected: these supported feature combinations compile without warnings. Gate or qualify the import consistently with its uses. Recorded on macOS during verification at base HEAD 12dc469; logs retained locally under tmp/pr66-astra-implementation/features-none.log and features-ws.log.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions