Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Problem
After upgrading to OpenWRT 24.10 (kernel 6.6), the USB3 disable logic stopped working. The vcgencmd bootloader_version command fails with ioctl_set_msg
failed:-1 because the VCHIQ kernel module is no longer built into the kernel.
Background
USB 3.0 signaling causes RF interference in the 2.4 GHz band, which degrades WiFi performance. We disable USB3 at runtime and force modems to
re-enumerate on the USB 2.0 hub.
Investigation
Explored moving USB3 disabling from runtime to build-time via device tree patches. This approach failed because:
Solution
The existing runtime approach (using uhubctl to power off the USB3 hub) is the correct solution. Updated the VL805 version check to be non-fatal when
vcgencmd is unavailable - all Pi 4 devices in the field have compatible firmware since the Pi 4 launched after the required firmware version (Sept
2019).
Update
This solution is incorrect
vcgencmdshould be available but isn't because we haven't updated our gpu firmware files. This pr shouldn't be needed and be fixed once we have a fix for updating gpu firmware files.Related Issues, Tickets & Documents
https://app.clickup.com/t/869bxadkw
Screenshots/Recordings
Manual test
Manual test description
scp'd over and tested. Need to test full build.
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?