Fix bug in resize_to_cover where the image is provided as a string#136
Merged
janko merged 4 commits intojanko:masterfrom Feb 8, 2025
Merged
Fix bug in resize_to_cover where the image is provided as a string#136janko merged 4 commits intojanko:masterfrom
janko merged 4 commits intojanko:masterfrom
Conversation
Contributor
Author
|
Such bizarre test failures! |
Owner
|
Great, thanks!
Yeah, just ignore those, I'll look into them later. |
Contributor
Author
|
Would it be possible to get a gem release with this fix in it as I'd be keen to get it into production :D |
Owner
|
Released in 1.14.0 🚀 |
Contributor
Author
|
Thanks @janko, deploying now :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This appears to be a good fix. My original implementation always assumed
imageexisted because we didn't useresize_toin the method name:image_processing/lib/image_processing/processor.rb
Lines 9 to 16 in 56a839e
Not sure if there are any functional differences in how we load the image here and how it's loaded in
processor.rb.Probably the better fix would be to use another system for determining which methods need the image to be loaded first rather than relying on the method name.
Closes #134