Filter source with lib.fileset#33
Merged
Merged
Conversation
Replaces `callCabal2nix "template-project" ../. {}` with an explicit
`lib.fileset.toSource` that unions only app/, src/, test/, the cabal
file, LICENSE, Readme.md and Changelog.md. This addresses the existing
note that nix/tooling files were considered for the build, and so the
cabal2nix-driven derivation no longer rebuilds when shell.nix,
nix/hpkgs.nix, .github/, makefile, .hlint.yaml etc. change.
Verified locally with `nix-build` — template-1.0.0 builds and the
unit test suite (5 tests) passes.
Prompt: go update my haskell-template-project, I want find grained
source filtereing like this: [lib.fileset.toSource snippet]
Tokens: ~25k
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
callCabal2nix "template-project" ../. {}with an explicitlib.fileset.toSourcethat unionsapp/,src/,test/,template.cabal,LICENSE,Readme.md, andChangelog.md.nix/hpkgs.nixabout nix and tooling files being considered part of the build input.shell.nix,nix/,.github/,makefile,.hlint.yaml,.stylish-haskell.yaml,brittany.yaml, etc. no longer invalidates the cabal2nix-driven haskell build cache.Test plan
nix-buildbuildstemplate-1.0.0and the unit suite (5 tests) passes locally.🤖 Generated with Claude Code