Exercise 2 python. #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improved comments and doc strings
jarbesfeld
reviewed
Jul 17, 2024
|
|
||
| def __init__(self, start_time, end_time, delta): | ||
| """ Initializes the observations associated with a TIEGCM experiment | ||
| """ Initialize the window and model times associated with a TIEGCM experiment |
Owner
There was a problem hiding this comment.
it would be good to clarify what TIEGCM means
jarbesfeld
reviewed
Jul 17, 2024
| """ | ||
|
|
||
| # Error checking of delta input |
Owner
There was a problem hiding this comment.
it would be good to add documentation indicating why these numbers were added for the conditions
jarbesfeld
reviewed
Jul 17, 2024
| start_time - string '%Y-%m-%d %H:%M:%S' model start time of experiment | ||
| end_time - string '%Y-%m-%d %H:%M:%S' model end time of experiment | ||
| start_time - string '%Y-%m-%d %H:%M:%S' model inital time |
Owner
There was a problem hiding this comment.
there is a typo in inital (should be initial)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added error checking to window calculation script.
Fixes issue
Fixes #8 python