Audit sweep: make CI actually run, and actually check the serve/API + optimizer layers

[jarmstrong158]

Four fixes, all variations on one theme: signals that looked green while checking nothing.

1. CI stopped running when the branch was renamed

.github/workflows/ci.yml gated push and pull_request on branches: [master].

Correction to my first commit message: I initially claimed no master ref had ever existed and that this workflow had never run. Opening this PR disproved that — GitHub's run history shows CI ran successfully on master, most recently on 2026-06-07 (run 27101863487, commit 1d6f015). Commit c36991a corrects the comment I wrote in 9f9facc.

The real defect is narrower and worse-behaved than a typo. The gate was correct when written. The default branch was later renamed master → main, and nothing updates a workflow's branch filter on rename — so the workflow silently stopped firing. No error, no warning, no failed run. Just an absence, which is the one failure mode a dashboard cannot show you. Everything that landed on main after the rename went in with no CI at all, and the checks on this PR are the first run since.

Its own header comment reads "Passing tests must not depend on local discipline." A rename quietly switching CI off is exactly that. Both gates now point at main.

2. CI was set up to silently skip ~27 tests

dev was ["pytest>=8", "httpx>=0.27"], but four test modules opened with pytest.importorskip on fastapi / httpx / ortools. In a clean environment every one of those guards resolved to skip, so the entire serve/API layer and the CP-SAT optimizer were never executed and the run still reported green.

Measured, not assumed:

environment	result
clean venv, old dev extra (CI mirror)	503 passed, 6 skipped
ambient dev machine (happened to have the deps)	530 passed, 4 skipped
this branch	535 passed, 4 skipped

That 27-test gap is the serve API, the per-facility agent loader, /compare + /calendar_check, and the CP-SAT bound. It passed locally only because the ambient interpreter happened to have the packages installed — precisely the local-discipline dependence the workflow exists to eliminate.

Both halves were necessary:

• dev now pulls in clark[serve,optimizer], so anything added to those extras is automatically armed in CI rather than needing a second manual edit.
• The importorskip guards are deleted. importorskip is the right tool for a dependency that is genuinely optional to the thing under test, and the wrong tool for one the test requires — in a CI summary a skip is indistinguishable from a pass.

tests/test_optional_deps.py is the loud, named tripwire: it asserts each optional dep imports and that the CP-SAT native solver actually solves a model, so an incomplete install yields one clear message naming the missing extra instead of a wall of collection errors. (These 5 tests are the entire difference between 530 and 535.)

3. ortools was undeclared

clark/inference/optimizer.py imports ortools inside plan_day, but the package appeared nowhere in pyproject.toml. The CP-SAT bound that the README and ENGINEERING_NOTES §10 both advertise died on a clean install with a bare ImportError.

New optimizer extra declares it. The README reproduction line now separates the heuristic comparison from the CP-SAT bound and gives the real command; ENGINEERING_NOTES §10 names the extra where the module is introduced; and the ImportError itself now points at pip install -e ".[optimizer]" rather than a bare package name.

4. Housekeeping

• .gitignore: .venv/ → .venv*/. A 736MB .venv-ci/ (the clean-install mirror that exposed the skip gap) sat untracked and unignored because the exact-name rule missed it. Deliberately not adding env/ — it would shadow the tracked clark/env/ source package.
• HF model card: 4 /blob/master/ links, dead since the same rename. Includes the license link in the YAML front-matter — the one a reuser is most likely to click.

Verification

Full suite run locally against the final state of this branch: 535 passed, 4 skipped, zero failures. The remaining 4 skips are intentional and self-describing (CLARK_RUN_SLOW gates and facility-shape guards), not dependency skips.

pip install -e ".[dev]" was dry-run verified to resolve the self-referential extra — setuptools emits Requires-Dist: clark[optimizer,serve]; extra == "dev" and pip pulls ortools, fastapi, and uvicorn in transitively.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

🤖 Generated with Claude Code